After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722355 - #!/usr/bin/python in tools/fix_gir.py
#!/usr/bin/python in tools/fix_gir.py
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 16:45 UTC by Ting-Wei Lan
Modified: 2014-01-31 03:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: run fix_gir.py with $(PYTHON) (840 bytes, patch)
2014-01-17 03:16 UTC, Daiki Ueno 		committed Details | Review

Description Ting-Wei Lan 2014-01-16 16:45:28 UTC 
Some systems may not have python installed in /usr/bin. Using /usr/bin/env to find python is more portable. Can we change it to #!/usr/bin/env python?
Comment 1 Daiki Ueno 2014-01-17 03:16:09 UTC 
Created attachment 266514 [details] [review]
build: run fix_gir.py with $(PYTHON)

--
Good catch, thanks.  However, /usr/bin/env might pick a python executable different from the one found by ./configure.  I'd rather change the caller to directly call $(PYTHON).
Comment 2 Ting-Wei Lan 2014-01-17 07:33:19 UTC 
This patch works.
Comment 3 Daiki Ueno 2014-01-31 03:42:03 UTC 
Attachment 266514 [details] pushed as 42e6418 - build: run fix_gir.py with $(PYTHON)