GNOME Bugzilla – Bug 722354
autogen warnings
Last modified: 2014-04-30 07:32:38 UTC
client/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') common/Makefile.am:6: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') daemon/Makefile.am:32: warning: '%'-style pattern rules are a GNU make extension daemon/Makefile.am:39: warning: '%'-style pattern rules are a GNU make extension daemon/Makefile.am:42: warning: '%'-style pattern rules are a GNU make extension daemon/Makefile.am:7: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') man/Makefile.am:9: warning: '%'-style pattern rules are a GNU make extension man/Makefile.am:12: warning: '%'-style pattern rules are a GNU make extension man/Makefile.am:38: warning: patsubst %.1,%.xml,${patsubst %.7,%.xml,$(man_MANS): non-POSIX variable name man/Makefile.am:38: (probably a GNU make extension) metadata/Makefile.am:68: warning: '%'-style pattern rules are a GNU make extension metadata/Makefile.am:33: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') programs/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') test/Makefile.am:28: warning: '%'-style pattern rules are a GNU make extension test/Makefile.am:29: warning: *F: non-POSIX variable name configure: WARNING: unrecognized options: --Remove
Created attachment 266482 [details] [review] replace obsolete INCLUDES
Created attachment 266483 [details] [review] remove maintainer mode
Is it possible to change %'-style pattern rules to be portable? Or we don't care about portability, so fix it by -Wno-portability?
Review of attachment 266482 [details] [review]: Looks good otherwise! ::: client/Makefile.am @@ +1,3 @@ NULL = +AM_CPPFLAGS = -I$(top_srcdir) \ The INCLUDES variable is used later: test_uri_utils_CFLAGS = $(INCLUDES) This should be fixed up...
Review of attachment 266483 [details] [review]: Looks good!
Comment on attachment 266482 [details] [review] replace obsolete INCLUDES Fixed and pushed, thanks for review. commit 41994e8c32fb8a3a4fe9c441b1a57ac1d8fd2f1e
Comment on attachment 266483 [details] [review] remove maintainer mode commit 05218230f58891d8b87a56256452ca8342a77972
pretty sure this broke gvfs inside gnome-continuous: http://build.gnome.org/continuous/buildmaster/builds/2014/01/17/26/build/log-gvfs.txt AFAIR, if you specify AM_CPPFLAGS and per-target _CPPFLAGS, only the latter will be used.
Fix have been committed recently. Sorry for that troubles... commit afd78d3945e383501e91ebf0a2845a075869a046
Created attachment 274739 [details] [review] build: Require gudev >= 147 From release 147, the gudev API was marked as stable, so require that version.
Created attachment 274740 [details] [review] build: Fix typo The FTP backend is always enabled regardless of the state of HTTP/DAV so don't include it in the message at the end of configure.
Created attachment 274741 [details] [review] build: Silence automake portability warnings Require GNU Make for now and so silence portability warnings.
I think it's OK to require GNU make for now so I attached a patch to silence the warnings. I also attached a couple of other random build fixes which I was too lazy to put in separate bugs :-P
Review of attachment 274739 [details] [review]: Looks good, but: ::: daemon/Makefile.am @@ -14,3 @@ $(OBEXFTP_CFLAGS) $(EXPAT_CFLAGS) \ $(KEYRING_CFLAGS) \ - -DG_UDEV_API_IS_SUBJECT_TO_CHANGE \ Remove this line also from: monitor/gphoto2/Makefile.am monitor/mtp/Makefile.am
Review of attachment 274740 [details] [review]: It looks good, thanks.
Review of attachment 274741 [details] [review]: Makes sense to put -Wno-portability there as is in many other gnome projects...
Pushed (with fixes) to master as 8ec1666eb2a42dad7e4bafe4545b0d945f4fbc29. Thanks for the reviews.