After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722350 - MapLocation: Re-add easing on goTo
MapLocation: Re-add easing on goTo
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 16:11 UTC by Mattias Bengtsson
Modified: 2015-11-16 09:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MapLocation: Re-add easing on goTo (1.63 KB, patch)
2014-01-16 16:11 UTC, Mattias Bengtsson
accepted-commit_now Details | Review

Description Mattias Bengtsson 2014-01-16 16:11:51 UTC
This patch re-adds easing on mapLocation.goTo for a much smoother
transition.

The problem before that made us go with clutters LINEAR animation mode
was that we do two animations, one to fit both locations and one to
then go to the target location. With an EASE_IN_OUT_* animation we would
get a really bad animation.

The solution in the patch below is to set the animation mode to
EASE_IN_CIRC, do the ensureVisible and then set it to EASE_OUT_CIRC.
Comment 1 Mattias Bengtsson 2014-01-16 16:11:53 UTC
Created attachment 266480 [details] [review]
MapLocation: Re-add easing on goTo

This patch re-adds easing on mapLocation.goTo for a much smoother
transition.
Comment 2 Zeeshan Ali 2014-01-16 19:34:45 UTC
Review of attachment 266480 [details] [review]:

ACK if you have tested it.
Comment 3 Mattias Bengtsson 2014-01-20 23:26:23 UTC
Yep, also added resetting of easing just to make sure.