After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722335 - non-void function should return a value
non-void function should return a value
Product: folks
Classification: Platform
Component: general
git master
Other FreeBSD
: Normal normal
: Unset
Assigned To: folks-maint
: 726499 (view as bug list)
Depends on:
Reported: 2014-01-16 13:55 UTC by Ting-Wei Lan
Modified: 2014-03-20 07:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Simple patch file (533 bytes, patch)
2014-01-16 13:55 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2014-01-16 13:55:54 UTC
Created attachment 266464 [details] [review]
Simple patch file

In tests/lib/test-case-helper.c, the function folks_test_case_add_test_helper uses g_return_if_fail, which should be replaced by g_return_val_if_val.
Comment 1 Philip Withnall 2014-01-16 22:57:53 UTC
Good catch, thanks for the patch! Pushed to master.
Comment 2 Philip Withnall 2014-03-20 07:50:43 UTC
*** Bug 726499 has been marked as a duplicate of this bug. ***