After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722334 - Make gnome-shell-extension-prefs a binary executable
Make gnome-shell-extension-prefs a binary executable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 13:47 UTC by Florian Müllner
Modified: 2014-01-16 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make gnome-shell-extension-prefs a binary executable (4.89 KB, patch)
2014-01-16 13:47 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-01-16 13:47:50 UTC 
Turns out extension-prefs have been broken for quite a while now ...
Comment 1 Florian Müllner 2014-01-16 13:47:53 UTC 
Created attachment 266461 [details] [review]
Make gnome-shell-extension-prefs a binary executable

Since commit 1ebb162a00bf6c4b0 moved JS sources into resources,
the extension-prefs tool was broken. To fix it, we would either
need to generate an external GResource in addition to the generated
C code and teach gjs-console about loading it before evaluating
the script, or turn gnome-shell-extension-prefs into a binary with
the JS resources compiled in.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-16 14:30:58 UTC 
Review of attachment 266461 [details] [review]:

Yeah, this looks good. My long-term plan is to have gjs-console learn how to load GResources, but for now this is fine.

::: src/gnome-shell-extension-prefs.c
@@ +20,3 @@
+  context = g_object_new (GJS_TYPE_CONTEXT,
+                          "search-path", search_path,
+                          "js-version", "1.8",

js-version was removed upstream.
Comment 3 Florian Müllner 2014-01-16 14:34:12 UTC 
Attachment 266461 [details] pushed as 2dd7db4 - Make gnome-shell-extension-prefs a binary executable