GNOME Bugzilla – Bug 722331
Applications view - Favourites / All transition is incomplete
Last modified: 2014-02-17 12:38:18 UTC
When you switch between Favourites / All in the applications view, some parts of the transition are abrupt: * The app launcher icons immediately disappear/appear. * When switching from All to Favourites, the page indicators simply disappear. We should probably fade the icons in and out when switching between views. The page indicators should also animate out in the same way that they animate in.
(In reply to comment #0) > * The app launcher icons immediately disappear/appear. No, they are faded very very quickly. Guess we should give the transition some more time ... > * When switching from All to Favourites, the page indicators simply disappear. Yeah, this struck me as odd when reviewing those patches, but Carlos claimed this was by design.
No, there's a bug where the app launcher icons, when loading for the first time, appear instead of fading. It happens even when having the slow down factor set to 10 or something, so it's not because they're loading.
(In reply to comment #1) > (In reply to comment #0) > > * The app launcher icons immediately disappear/appear. > > No, they are faded very very quickly. Guess we should give the transition some > more time ... > I'm just adding it =) seems Overview.controls_time to 0.12 is not enough for this. > > > * When switching from All to Favourites, the page indicators simply disappear. > > Yeah, this struck me as odd when reviewing those patches, but Carlos claimed > this was by design. I don't remember at all, but yeah I remember to ask this question, probably was a design decision from Jakub if I'm correct. Jakub what do you think?
Created attachment 266500 [details] [review] appDisplay: Add time to view switching animation Add more time to the fade in/out animation when switching views so they don't switch abruptly.
Review of attachment 266500 [details] [review]: ::: js/ui/appDisplay.js @@ +47,3 @@ const PAGE_SWITCH_TIME = 0.3; +const VIEWS_SWITCHING_TIME = 0.7; Meh, SWITCH instead of SWITCHING
Created attachment 266502 [details] [review] appDisplay: Add time to view switch animation Add more time to the fade in/out animation when switching views so they don't switch abruptly.
(In reply to comment #2) > No, there's a bug where the app launcher icons, when loading for the first > time, appear instead of fading. It happens even when having the slow down > factor set to 10 or something, so it's not because they're loading. True, I file a new bug for that.
(In reply to comment #1) ... > > * When switching from All to Favourites, the page indicators simply disappear. > > Yeah, this struck me as odd when reviewing those patches, but Carlos claimed > this was by design. Might be worth checking with Jakub about that, then. I'd fade them out at the very least though.
(In reply to comment #8) > (In reply to comment #1) > ... > > > * When switching from All to Favourites, the page indicators simply disappear. > > > > Yeah, this struck me as odd when reviewing those patches, but Carlos claimed > > this was by design. > > Might be worth checking with Jakub about that, then. I'd fade them out at the > very least though. Fading out now with latest patch.
For the bug when appDisplay is launched for first time and the icons are not fade in: https://bugzilla.gnome.org/show_bug.cgi?id=722383
Fadeout is a good transition for hiding them.
Created attachment 269059 [details] [review] appDisplay: Add time to view switch animation Add more time to the fade in/out animation when switching views so they don't switch abruptly.
Created attachment 269060 [details] [review] appDisplay: Add time to view switch animation Add more time to the fade in/out animation when switching views so they don't switch abruptly.
(In reply to comment #12) > Created an attachment (id=269059) [details] [review] > appDisplay: Add time to view switch animation > > Add more time to the fade in/out animation when switching > views so they don't switch abruptly. This is with 0.3 and (In reply to comment #13) > Created an attachment (id=269060) [details] [review] > appDisplay: Add time to view switch animation > > Add more time to the fade in/out animation when switching > views so they don't switch abruptly. with 0'5. I can't see the diference with 0.3 with current implementation (0.12). For me seems noticeable and nicer with 0.5. But Jakub prefer in principle with 0.3. We go with 0.3 then?
Created attachment 269131 [details] [review] appDisplay: Add time to view switch animation Add more time to the fade in/out animation when switching views so they don't switch abruptly.
Created attachment 269132 [details] [review] appDisplay: Add time to view switch animation Add more time to the fade in/out animation when switching views so they don't switch abruptly and add a delay between view switch animations to avoid morphing.
Review of attachment 269132 [details] [review]: LG, fine to push assuming a design ack.
(In reply to comment #16) > Created an attachment (id=269132) [details] [review] > appDisplay: Add time to view switch animation ... Thanks Carlos! This works well for me with the following values: VIEWS_SWITCH_TIME = 0.4; VIEWS_SWITCH_ANIMATION_DELAY = 0.1;
Attachment 269132 [details] pushed as 314aa02 - appDisplay: Add time to view switch animation