After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722322 - check coordinate validity in do_pick()
check coordinate validity in do_pick()
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: ClutterStage
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 11:19 UTC by Emmanuele Bassi (:ebassi)
Modified: 2014-01-23 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
stage: Check coordinate validity in do_pick() (4.75 KB, patch)
2014-01-16 11:19 UTC, Emmanuele Bassi (:ebassi)
none Details | Review

Description Emmanuele Bassi (:ebassi) 2014-01-16 11:19:26 UTC
instead of relying on call sites doing it for us.
Comment 1 Emmanuele Bassi (:ebassi) 2014-01-16 11:19:33 UTC
Created attachment 266440 [details] [review]
stage: Check coordinate validity in do_pick()

We do some argument validation inside _clutter_stage_do_pick(), which is
the internal version of clutter_stage_get_actor_at_pos(), but we don't
do coordinate space validation, and instead we rely on call sites doing
the right thing.

We should, instead, remove the argument validation from the internal
function, which is pointless and against the coding practices, but do
coordinate space validation internally.
Comment 2 Emmanuele Bassi (:ebassi) 2014-01-23 12:54:16 UTC
attachment 266440 [details] [review] pushed to clutter-1.18