After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722318 - Home emails are displayed as 'Other'
Home emails are displayed as 'Other'
Status: RESOLVED OBSOLETE
Product: gnome-contacts
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
: 729904 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-16 10:58 UTC by Vadim Rutkovsky
Modified: 2018-01-24 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix set type for email in new contact dialog (1.29 KB, patch)
2014-01-27 03:23 UTC, Fernando Fernández
committed Details | Review

Description Vadim Rutkovsky 2014-01-16 10:58:15 UTC
Description of problem:
Emails set to 'Home' during contact create/import are displayed as 'Other'

Version-Release number of selected component (if applicable):
gnome-contacts-3.10.1-3.fc21.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Create a new contact and set Home Email to any value
2. Check details for created contact

Actual results:
Email is displayed as 'Other'

Expected results:
Email is displayed as 'Home' or 'Personal'

Additional info:
Email type is displayed correctly after editing contact and setting email type to 'Personal'
Comment 1 Fernando Fernández 2014-01-27 03:23:06 UTC
Created attachment 267269 [details] [review]
Fix set type for email in new contact dialog

The typeset in pack_entry_combo call for emails to recive TypeSet.email. Also I've modified NewContactDialog.pack_entry_combo method to set to "PERSONAL" if the the typeset is for emails.

Another way to fix it could be create an especific method for email pack_entry_combo, like pack_address_combo.

best regards

Fernando Fernandez- Software Peronista
Comment 2 Erick Perez Castellanos 2014-02-12 19:48:47 UTC
Fixed in master
Pushed: https://git.gnome.org/browse/gnome-contacts/commit/?id=a384b1ccc1f9a4a7dd75d75431495ce5c28f32d7
Comment 3 Vadim Rutkovsky 2015-04-08 09:24:17 UTC
Reopening as it still happens on 

evolution-data-server-3.16.0-1.fc23.x86_64
gnome-contacts-3.16.0-1.fc23.x86_64
Comment 4 Erick Perez Castellanos 2015-04-23 04:46:02 UTC
*** Bug 729904 has been marked as a duplicate of this bug. ***
Comment 5 Erick Perez Castellanos 2015-04-23 06:07:58 UTC
Home emails solved in commit 3e361a9.

There's still the problem of the Personal tag we set on email and Google addressbook doesn't allow it, so it set it back to Other, and we show it. For the use who set the email as Personal it's a bug, we should handle it.
Comment 6 Erick Perez Castellanos 2015-04-23 16:27:26 UTC
(In reply to Vadim Rutkovsky from comment #3)
> Reopening as it still happens on 
> 
> evolution-data-server-3.16.0-1.fc23.x86_64
> gnome-contacts-3.16.0-1.fc23.x86_64

Fix pushed as commit 2b3c243. Can you test it on master and close the bug?
Comment 7 GNOME Infrastructure Team 2018-01-24 15:11:05 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-contacts/issues/44.