After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722307 - Preview: declare set_visible as an override method
Preview: declare set_visible as an override method
Status: RESOLVED FIXED
Product: quadrapassel
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: quadrapassel-maint
quadrapassel-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 01:19 UTC by Michael Catanzaro
Modified: 2014-01-20 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Preview: declare set_visible as an override method (771 bytes, patch)
2014-01-16 01:19 UTC, Michael Catanzaro 		needs-work Details | Review
Preview: declare set_visible as a new method (761 bytes, patch)
2014-01-17 03:17 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-01-16 01:19:08 UTC 
I doubt this affects anything, I just noticed a warning.
Comment 1 Michael Catanzaro 2014-01-16 01:19:09 UTC 
Created attachment 266422 [details] [review]
Preview: declare set_visible as an override method
Comment 2 Mario Wenzel 2014-01-16 09:01:53 UTC 
Review of attachment 266422 [details] [review]:

This doesn't work for me.

preview.vala:131.5-131.36: error: Preview.set_visible: no suitable method found to override
    public override void set_visible(bool visible)
Comment 3 Michael Catanzaro 2014-01-17 02:08:25 UTC 
Er... maybe I did not test this at all?
Comment 4 Michael Catanzaro 2014-01-17 03:16:50 UTC 
I guess I have to use new instead of override because the method is not declared virtual.  This isn't very impressive....
Comment 5 Michael Catanzaro 2014-01-17 03:17:24 UTC 
Created attachment 266515 [details] [review]
Preview: declare set_visible as a new method
Comment 6 Mario Wenzel 2014-01-20 19:35:46 UTC 
Review of attachment 266515 [details] [review]:

Looks alright and is now in master.