After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722278 - Implement some throttling
Implement some throttling
Status: RESOLVED FIXED
Product: gnome-online-miners
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Miners maintainer(s)
GNOME Online Miners maintainer(s)
Depends on:
Blocks: 721402
 
 
Reported: 2014-01-15 17:15 UTC by Debarshi Ray
Modified: 2014-01-23 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
miner-main: Lower the CPU and disk I/O scheduling and priority (10.90 KB, patch)
2014-01-16 09:20 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-01-15 17:15:32 UTC 
We need to atleast implement some kind of CPU and I/O throttling, otherwise it gets pretty dire when a user has lots of data on the server. See: https://bugzilla.gnome.org/show_bug.cgi?id=721402

We can take some ideas from Tracker's builtin miners.
Comment 1 Debarshi Ray 2014-01-16 09:20:24 UTC 
Created attachment 266434 [details] [review]
miner-main: Lower the CPU and disk I/O scheduling and priority
Comment 2 Debarshi Ray 2014-01-16 09:25:14 UTC 
This is still very basic. There is room for improvement:
 - We should throttle the network I/O if we are on some expensive network connection.
 - Look at the battery status and throttle accordingly.
Comment 3 Cosimo Cecchi 2014-01-17 00:45:27 UTC 
Review of attachment 266434 [details] [review]:

This looks good to me - it would be nice to share this - and maybe even other parts - infrastructure with Tracker, maybe by moving it to TrackerMiner, but let's not block on that.
Comment 4 Debarshi Ray 2014-01-17 06:34:37 UTC 
(In reply to comment #3)
> Review of attachment 266434 [details] [review]:

Thanks for the review.

> and maybe even other
> parts - infrastructure with Tracker, maybe by moving it to TrackerMiner, but
> let's not block on that.

There is the TrackerMiner base class for implementing miners which would be the way to share other parts of the infrastructure.
Comment 5 Debarshi Ray 2014-01-17 06:36:47 UTC 
Keeping the bug open till we ascertain that the user-facing problem in bug 721402 has been addressed.
Comment 6 Debarshi Ray 2014-01-23 12:02:37 UTC 
After a bit of testing I can say that this does help a lot.

Ofcourse this is still Linux-only, and we can still improve (comment 2), but for the moment this is good enough.