GNOME Bugzilla – Bug 722249
[PATCH] Allow disabling libuhttpmock dependency with --disable-tests
Last modified: 2014-08-24 14:17:46 UTC
Created attachment 266345 [details] [review] allow-disabling-libuhttpmock.patch Extra uhttpmock dependency is unneeded for most people who use source based distros. Therefore I suggest adding a --disable-tests to allow building without the need for uhttpmock library. By default its still needed.
Review of attachment 266345 [details] [review]: Have you checked this still passes `make check` with --enable-tests and --disable-tests? ::: Makefile.am @@ +3,3 @@ +if ENABLE_TESTS + SUBDIRS += gdata/tests +endif If making SUBDIRS conditional, you need to add DIST_SUBDIRS to ensure the ‘tests’ directory makes it into dist tarballs.
It "passes" tests with --disable-tests. And it *should* work with --enable-tests too, because this is the old behaviour anyway. Do you know if there's a way to make's `make check` to print out "Tests disabled. Please run configure with --enable-tests to run tests" message?
(In reply to comment #2) > It "passes" tests with --disable-tests. And it *should* work with > --enable-tests too, because this is the old behaviour anyway. I’d appreciate it if you double-check please (and also try `make distcheck` just to be sure), since these things have a habit of breaking. > Do you know if there's a way to make's `make check` to print out "Tests > disabled. Please run configure with --enable-tests to run tests" message? Hmm. Try adding the following to Makefile.am: check-local if !ENABLE_TESTS @echo "*** WARNING ***: Functional tests disabled. Re-configure with --enable-tests to run them." endif
I'm not interested in spending any of my own time faffing around with the build system to implement this. If someone wants to provide a tested patch for it (noting that the existing patch also needs to add DISTCHECK_CONFIGURE_FLAGS = --enable-tests), I'll be happy to merge it. Please re-open the bug if so.