After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722243 - Implement new signal client::pre-play-request
Implement new signal client::pre-play-request
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Linux
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-15 09:13 UTC by Ognyan Tonchev (redstar_)
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implement new signal client::pre-play-request (2.65 KB, patch)
2014-01-15 09:13 UTC, Ognyan Tonchev (redstar_) 		none Details | Review
Emit signal when a state change is about to happen (4.03 KB, patch)
2014-01-21 11:09 UTC, Ognyan Tonchev (redstar_) 		committed Details | Review

Description Ognyan Tonchev (redstar_) 2014-01-15 09:13:58 UTC 
Created attachment 266341 [details] [review]
Implement new signal client::pre-play-request

The attached patch implements a new signal client::pre-play-request which is emitted before handling RTSP PLAY. This lets the application to do some initializations before play.
Comment 1 Ognyan Tonchev (redstar_) 2014-01-21 11:09:17 UTC 
Created attachment 266848 [details] [review]
Emit signal when a state change is about to happen

Wim, what do you think about this patch instead? And further on, what do you think about also emitting the already existing new-state signal not only from media_set_state() but also after preroll and suspend for completeness sake?
Comment 2 Wim Taymans 2014-01-21 13:48:34 UTC 
Not sure what to do with the other signals.

commit e04d9ac34d3b52fd49115c6ea0e1d1dcddeb50a7
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Tue Jan 21 14:46:47 2014 +0100

    media: refactor state change functions and signals
    
    Make functions to set the target state and the pipeline state and emit
    the signals from those functions.

commit 5eca958d5ea090949091e593a83d4a24abf5c5df
Author: Ognyan Tonchev <ognyan@axis.com>
Date:   Tue Jan 21 12:01:25 2014 +0100

    media: add signal to notify of pending state changes