Created attachment 266295 [details] [review]
Do not place maki icons in own directory

It breaks the install-icons hook and results in icons being installed in
  ${datadir}/icons/gnome/maki/scalable/places/[...]

Review of attachment 266295 [details] [review]:

::: icons/Makefile.am
@@ +6,3 @@
+	scalable_places_poi-marker.svg \
+	scalable_places_poi-railway-station.svg \
+	scalable_places_poi-town.svg

this break diskcheck then.

(In reply to comment #2)
> Review of attachment 266295 [details] [review]:
> 
> ::: icons/Makefile.am
> @@ +6,3 @@
> +    scalable_places_poi-marker.svg \
> +    scalable_places_poi-railway-station.svg \
> +    scalable_places_poi-town.svg
> 
> this break diskcheck then.

I doubt it... as the patch also moved the files from maki/ to ./

but I see you addressed this in a different way (which takes the main point of the subdirectory out of the useful part as well: now all icons must live in maki/ )

(In reply to comment #3)
> (In reply to comment #2)
> > Review of attachment 266295 [details] [review] [details]:
> > 
> > ::: icons/Makefile.am
> > @@ +6,3 @@
> > +    scalable_places_poi-marker.svg \
> > +    scalable_places_poi-railway-station.svg \
> > +    scalable_places_poi-town.svg
> > 
> > this break diskcheck then.
> 
> I doubt it... as the patch also moved the files from maki/ to ./

Ah sorry, I missed that part of the patch. :(

> but I see you addressed this in a different way (which takes the main point of
> the subdirectory out of the useful part as well: now all icons must live in
> maki/ )

I think they are there for a good reason. I'd rather move the Makefile rules into maki dir.