After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722188 - atk_text_get_n_selections() should return 0 when no text is selected
atk_text_get_n_selections() should return 0 when no text is selected
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: cally
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
: 677485 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-14 15:31 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-01-14 18:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
accessible-event listener (429 bytes, text/x-python)
2014-01-14 15:31 UTC, Joanmarie Diggs (IRC: joanie)
  Details
Compute properly if there is text selected (1.21 KB, patch)
2014-01-14 17:47 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-01-14 15:31:02 UTC
Created attachment 266268 [details]
accessible-event listener

Steps to reproduce:
1. Launch the attached accessible-event listener in a terminal
2. Press Alt+F2 to get into gnome-shell's run dialog
3. Type some text
4. Left arrow to move the caret character by character

Expected results: 0 selections would be reported each time Left arrow is pressed because no text is selected. (Compare with a GtkTextView or similar widget.)

Actual results: 1 selection is reported each time Left arrow is pressed with the exception of offset 0.

Impact: Orca ignores caret-moved events when there is also selected text because when there is a text selection, Orca should present the changes in selection (which it does in response to text-selection-changed signals) instead of the new caret location.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-01-14 17:47:23 UTC
Created attachment 266281 [details] [review]
Compute properly if there is text selected

selection_bound is relative to cursor_pos, not to 0.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-01-14 17:48:16 UTC
Note: I didn't test this with gnome-shell, but with a clutter example.

Note2: in case of accepting this, where should I commit this? On master and clutter-1.18?
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-01-14 17:49:13 UTC
*** Bug 677485 has been marked as a duplicate of this bug. ***
Comment 4 Joanmarie Diggs (IRC: joanie) 2014-01-14 18:05:54 UTC
Just verified this works/solves the problem. Thanks!!
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2014-01-14 18:10:18 UTC
(In reply to comment #4)
> Just verified this works/solves the problem. Thanks!!

Ok, so lets push it.

(In reply to comment #2)
> Note2: in case of accepting this, where should I commit this? On master and
> clutter-1.18?

From IRC:
<ebassi> API: ACK for clutter-1.16 and clutter-1.18

Pushed to both clutter-1.16 and clutter-1.18. Closing bug.