After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722183 - Can not build without libtiff installed
Can not build without libtiff installed
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Robert Roth
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2014-01-14 14:14 UTC by Robert Roth
Modified: 2014-01-19 11:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (968 bytes, patch)
2014-01-14 14:18 UTC, Robert Roth 		committed Details | Review
Proposed patch (968 bytes, patch)
2014-01-14 14:35 UTC, Robert Roth 		committed Details | Review

Description Robert Roth 2014-01-14 14:14:00 UTC 
I don't have libtiff installed, and with master checked out, build fails because of get_pixbuf_type_from_mime_type missing, but used from extensions/cairo_io/gth-image-saver-tiff.c [1].

This looks like something introduced back in August of 2012, 
see commit [2] moving get_pixbuf_type_from_mime_type functionto _gdk_pixbuf_get_type_from_mime_type.

[1] https://git.gnome.org/browse/gthumb/tree/extensions/cairo_io/gth-image-saver-tiff.c#n532
[2] https://git.gnome.org/browse/gthumb/commit/?id=f114b3f88ef5d6f6a36d25fb2a3289f9105d32c1
Comment 1 Robert Roth 2014-01-14 14:18:44 UTC 
Created attachment 266262 [details] [review]
Proposed patch

This proposed patch follows what has been done in the commit renaming the missing function, and uses the function with the new name.
Comment 2 Robert Roth 2014-01-14 14:35:59 UTC 
Created attachment 266265 [details] [review]
Proposed patch

The proposed fix uses the new function name.
Comment 3 Robert Roth 2014-01-14 14:36:40 UTC 
Sorry for the duplicate patch proposal, got an internal server error 500 and retried.
Comment 4 Paolo Bacchilega 2014-01-19 11:21:55 UTC 
Patch pushed to master, thank you.