After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721961 - Don't activate 'Move to new window' on popup menu when not needed
Don't activate 'Move to new window' on popup menu when not needed
Status: RESOLVED WONTFIX
Product: gedit
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-10 20:57 UTC by sébastien lafargue
Modified: 2014-01-11 16:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't activate 'Move to new window' on popup menu when not needed (1.86 KB, patch)
2014-01-10 20:57 UTC, sébastien lafargue 		rejected Details | Review
rework of the previous patch using gedit_multi_notebook (1.83 KB, patch)
2014-01-10 22:09 UTC, sébastien lafargue 		committed Details | Review

Description sébastien lafargue 2014-01-10 20:57:13 UTC 
When there's only one tab, 'Move to new window' menu item must
be deactivated.
Comment 1 sébastien lafargue 2014-01-10 20:57:45 UTC 
Created attachment 265971 [details] [review]
Don't activate 'Move to new window' on popup menu when not needed
Comment 2 Ignacio Casal Quinteiro (nacho) 2014-01-10 21:19:33 UTC 
Review of attachment 265971 [details] [review]:

I left it as this on purpose. The tab group is insensitive but not the one to the window since it is a valid use case.
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-01-10 21:20:09 UTC 
Closing as WONTFIX as from the previous comment. Thanks anyway for the patch.
Comment 4 sébastien lafargue 2014-01-10 22:09:22 UTC 
Created attachment 265975 [details] [review]
rework of the previous patch using gedit_multi_notebook
Comment 5 Ignacio Casal Quinteiro (nacho) 2014-01-10 22:16:43 UTC 
Review of attachment 265975 [details] [review]:

Looks good.