After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721952 - some gedit gapplication cleanups
some gedit gapplication cleanups
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-10 18:13 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-11 05:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename app.new_window to app.new-window (1.33 KB, patch)
2014-01-10 18:13 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
preferences: associate the window with the app (1.80 KB, patch)
2014-01-10 18:13 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2014-01-10 18:13:44 UTC 
Here are a couple of patches to improve the usability of gedit with the
'gapplication' commandline tool.

The first patch allows the new-window action to be invoked with the
tool.  Before, it would say:

  $ gapplication action org.gnome.Gedit new_window
  invalid action name: 'new_window'

The second patch allows the preferences dialog to be opened with the
tool, even if gedit was not already running.  It also ensures that new
windows created while the preferences dialog is the only thing on the
screen are created in the proper way.
Comment 1 Allison Karlitskaya (desrt) 2014-01-10 18:13:45 UTC 
Created attachment 265960 [details] [review]
Rename app.new_window to app.new-window

Underscores should not appear in action names.
Comment 2 Allison Karlitskaya (desrt) 2014-01-10 18:13:48 UTC 
Created attachment 265961 [details] [review]
preferences: associate the window with the app

This allows the app to stay open if the preferences window is open.

Also, allow the preferences window to be created without a transient
window for it to be associated with.

Make sure we never return the preferences window as the active window.
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-01-10 19:14:50 UTC 
Review of attachment 265960 [details] [review]:

go ahead.
Comment 4 Ignacio Casal Quinteiro (nacho) 2014-01-10 19:16:21 UTC 
Review of attachment 265961 [details] [review]:

Looks good.
Comment 5 Allison Karlitskaya (desrt) 2014-01-11 05:51:57 UTC 
Attachment 265960 [details] pushed as 6cc8d70 - Rename app.new_window to app.new-window
Attachment 265961 [details] pushed as a5ad3ed - preferences: associate the window with the app