After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721951 - users: Improve logged-in check when deleting users
users: Improve logged-in check when deleting users
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-10 17:55 UTC by Matthias Clasen
Modified: 2014-01-10 18:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
users: Improve logged-in check when deleting users (1.39 KB, patch)
2014-01-10 17:55 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-01-10 17:55:07 UTC
When deleting a user account, we try to check if the user is
still logged in, but we are using an accountsservice API that
ignores console logins. But deleting a user that is logged
in on the console is just as bad, so use
act_user_is_logged_in_anywhere instead, which includes console
logins.
Comment 1 Matthias Clasen 2014-01-10 17:55:09 UTC
Created attachment 265958 [details] [review]
users: Improve logged-in check when deleting users
Comment 2 Ondrej Holy 2014-01-10 18:00:39 UTC
Review of attachment 265958 [details] [review]:

Looks good!
Comment 3 Matthias Clasen 2014-01-10 18:07:32 UTC
Attachment 265958 [details] pushed as 2991d70 - users: Improve logged-in check when deleting users