After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721918 - Fix compilation after API break in Cogl 1.17
Fix compilation after API break in Cogl 1.17
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 721901 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-10 10:09 UTC by Emmanuele Bassi (:ebassi)
Modified: 2014-01-13 19:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update call to cogl_texture_2d_new_from_data() (1.66 KB, patch)
2014-01-10 10:10 UTC, Emmanuele Bassi (:ebassi) 		accepted-commit_now Details | Review

Description Emmanuele Bassi (:ebassi) 2014-01-10 10:09:56 UTC 
Cogl 1.17 changed the API of the specialized constructors of the
CoglTexture interface implementation.

We need to bump the dependency on Cogl, and change the lone call
to cogl_texture_2d_new_from_data() inside Mutter.
Comment 1 Emmanuele Bassi (:ebassi) 2014-01-10 10:10:03 UTC 
Created attachment 265900 [details] [review]
Update call to cogl_texture_2d_new_from_data()
Comment 2 Giovanni Campagna 2014-01-10 10:14:08 UTC 
*** Bug 721901 has been marked as a duplicate of this bug. ***
Comment 3 Giovanni Campagna 2014-01-10 10:14:35 UTC 
IMHO, Cogl should revert the change, and postpone it until 2.0.
Comment 4 Giovanni Campagna 2014-01-10 10:15:33 UTC 
Review of attachment 265900 [details] [review]:

Good iff we don't get an agreement with cogl maintainers on a revert.
Comment 5 Emmanuele Bassi (:ebassi) 2014-01-10 10:19:23 UTC 
to be fair, the API changed is the unstable/experimental one, which has no guarantee between minor versions.

on the other hand, though, they avoided changing cogl_texture_rectangle_new_for_size() because Mutter is using it, so I guess they could avoid touching cogl_texture_2d_new_from_data() under the same reasoning.
Comment 6 Jasper St. Pierre (not reading bugmail) 2014-01-10 16:32:21 UTC 
In my opinion, I'm fine with either breaking API/ABI or keeping it. These were experimental. But I think we should do it consistently: if we want to break API/ABI, break texture_rectangle as well. If we want to keep API/ABI, keep new_from_data as well.