After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721888 - Pitivi's clipmediaprops.py should handle nonsensical framerates such as 0 fps
Pitivi's clipmediaprops.py should handle nonsensical framerates such as 0 fps
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Media library
Git
Other Linux
: Normal normal
: 0.93
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-09 20:00 UTC by Jean-François Fortin Tam
Modified: 2014-03-17 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Jean-François Fortin Tam 2014-01-09 20:00:25 UTC 
wget jeff.ecchi.ca/public/00108.MTS

gst-discoverer-1.0 -v 00108.MTS |grep -i frame
      Frame rate: 0/1

...resulting in Pitivi seeing the clip as being 0 fps. Oops :)
Comment 1 Sebastian Dröge (slomo) 2014-01-10 08:51:07 UTC 
What's the problem with that? :) 0/1 in general means variable framerate or we don't know the framerate.

Also with git master and 1.2.2 here:
gst-discoverer-1.0 00108.MTS -v | grep frame
      Frame rate: 30000/1001
Comment 2 Jean-François Fortin Tam 2014-01-10 18:48:19 UTC 
Alright so the onus is on application developers to discard such values if encountered.

Pitivi will have to take a defensive approach and prevent setting a nonsensical project framerate from a clip whose framerate has been misdetected.
Comment 3 Jean-François Fortin Tam 2014-03-17 16:51:03 UTC 
commit 489d514de7727027fe776c7f3e992556d6f9d858
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Fri Jan 10 21:51:25 2014 -0500

    clipmediaprops: Prevent setting an invalid framerate from a misdetected clip
    
    Fixes bug #721888