After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721860 - pyatspi2 should not modify the end offset in getText()
pyatspi2 should not modify the end offset in getText()
Status: RESOLVED FIXED
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pyatspi2 maintainer(s)
pyatspi2 maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-01-09 12:18 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2016-04-01 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Joanmarie Diggs (IRC: joanie) 2014-01-09 12:18:40 UTC 
At https://git.gnome.org/browse/pyatspi2/tree/pyatspi/text.py#n407:

                if not endOffset:
                        endOffset = -1

As a result, one finds things like: https://bugzilla.mozilla.org/show_bug.cgi?id=957306

Oops.
Comment 1 André Klapper 2015-02-27 16:41:02 UTC 
[Moving at-spi/pyatspi2 bugs to separate product. See bug 740075]
Comment 2 Patrick Welche 2015-03-07 08:47:46 UTC 
Given the POLS, I would have expected getText() to pass its arguments on as is to atk_text_get_text(), and leave it up to atk_text_get_text() to return an empty string (NULL) if the arguments aren't to its liking. It looks as though those two lines should just go away...
Comment 3 Mike Gorse 2016-04-01 01:33:36 UTC 
Yeah, I'm not sure why that code was there, and I don't see any harm in removing it. I've taken out those two lines of code.
Also, I apologize for taking so long to fix this--I'd added it to my to-do list and then forgotten about it.

mnaster: 8f457b
gnome-3-20: 5009bd