After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721821 - rtspsrc: update pt map when using decoders
rtspsrc: update pt map when using decoders
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-08 19:36 UTC by Aleix Conchillo Flaqué
Modified: 2014-02-20 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add update-pt-map signal (3.21 KB, patch)
2014-01-08 19:47 UTC, Aleix Conchillo Flaqué 		none Details | Review

Description Aleix Conchillo Flaqué 2014-01-08 19:36:44 UTC 
If an RTP decoder is requested in rtspsrc (e.g. to add SRTP support), the source pad in rtspsrc will get the wrong caps.

When rtpptdemux signal request-pt-map is emitted, the rtspsrc request_pt_map callback will be called. This function returns stream->caps which have a media type obtained using the incoming transport (application/x-srtp).

There should be a way to update this outgoing caps.
Comment 1 Aleix Conchillo Flaqué 2014-01-08 19:47:53 UTC 
Created attachment 265748 [details] [review]
add update-pt-map signal

This is an attempt to solve this, but I'm not really convinced of it.

Actually, rtspsrc doesn't even expose RTP encoders/decoders. I'm adding them manually in rtspsrc. And, as I am modifying rtspsrc I could already change the request_pt_map to return the caps that I want.

May be a complete patch providing RTP encoders/decoders in rtspsrc would make more sense.
Comment 2 Aleix Conchillo Flaqué 2014-02-15 01:56:22 UTC 
I think this might be over complicated. The only supported rtspsrc source caps are application/x-rtp and application/x-rdt.

May be it would be easier to check if the incoming caps are application/x-srtp and if so request_pt_map should return application/x-rtp.

Does that make any sense?
Comment 3 Aleix Conchillo Flaqué 2014-02-20 21:08:12 UTC 
I think I am just going to close this and marking obsolete. If I see a real advantage I'll file it again.