After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721813 - filebrowser: don't set .primary-toolbar
filebrowser: don't set .primary-toolbar
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-08 18:03 UTC by Lars Karlitski
Modified: 2014-01-09 21:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
filebrowser: don't set .primary-toolbar (1.85 KB, patch)
2014-01-08 18:03 UTC, Lars Karlitski 		committed Details | Review
gedit file browser: style toolbar similar to the tab bar (1.20 KB, patch)
2014-01-08 18:04 UTC, Lars Karlitski 		committed Details | Review

Description Lars Karlitski 2014-01-08 18:03:43 UTC 
See patches.
Comment 1 Lars Karlitski 2014-01-08 18:03:45 UTC 
Created attachment 265730 [details] [review]
filebrowser: don't set .primary-toolbar

The toolbar in the file browser widget is not a primary toolbar, so
don't set that class.

Also, set some margins on the toolbar buttons which would otherwise look
too cramped when styled on a non-primary toolbar.
Comment 2 Lars Karlitski 2014-01-08 18:04:11 UTC 
Created attachment 265731 [details] [review]
gedit file browser: style toolbar similar to the tab bar
Comment 3 Paolo Borelli 2014-01-08 21:19:13 UTC 
Review of attachment 265730 [details] [review]:

Maybe use the new margin-end so that it works correctly also in RTL?
Comment 4 Paolo Borelli 2014-01-08 21:20:39 UTC 
Review of attachment 265731 [details] [review]:

looks good to me... if this looks ok also for gedit master, please push, otherwise wait for the redesign branch to land
Comment 5 Ignacio Casal Quinteiro (nacho) 2014-01-09 09:30:56 UTC 
The redesign branch landed already.
Comment 6 Lars Karlitski 2014-01-09 21:34:18 UTC 
Comment on attachment 265730 [details] [review]
filebrowser: don't set .primary-toolbar

Attachment 265730 [details] pushed as f298b90 - filebrowser: don't set .primary-toolbar
Comment 7 Lars Karlitski 2014-01-09 21:36:53 UTC 
Attachment 265731 [details] pushed as b649243 - gedit file browser: style toolbar similar to the tab bar