After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721798 - Use proper function to remove ( unset ) metadata attributes
Use proper function to remove ( unset ) metadata attributes
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-08 16:04 UTC by sébastien lafargue
Modified: 2014-01-08 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use proper function to remove ( unset ) metadata attributes (965 bytes, patch)
2014-01-08 16:05 UTC, sébastien lafargue
accepted-commit_now Details | Review

Description sébastien lafargue 2014-01-08 16:04:09 UTC
Some code use null instead of a string so Gio complain :
    
    GLib-GIO-CRITICAL **:
     _g_file_attribute_value_get_string: assertion
    'attr->type == G_FILE_ATTRIBUTE_TYPE_STRING' failed

In fact, in code, the attribute is set to G_FILE_ATTRIBUTE_TYPE_INVALID
instead of being removed.
Comment 1 sébastien lafargue 2014-01-08 16:05:00 UTC
Created attachment 265719 [details] [review]
Use proper function to remove ( unset ) metadata attributes
Comment 2 Sébastien Wilmet 2014-01-08 18:16:07 UTC
The commit is pushed, thanks.