After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721737 - Fix a couple of header issues
Fix a couple of header issues
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.11.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-01-07 21:33 UTC by Allison Karlitskaya (desrt)
Modified: 2014-01-08 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove #include <malloc.h> from a file (886 bytes, patch)
2014-01-07 21:33 UTC, Allison Karlitskaya (desrt)
committed Details | Review
tests: #include <sys/wait.h> for WIFEXITED (724 bytes, patch)
2014-01-07 21:33 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2014-01-07 21:33:28 UTC
These help evolution-data-server build on FreeBSD.
Comment 1 Allison Karlitskaya (desrt) 2014-01-07 21:33:29 UTC
Created attachment 265592 [details] [review]
Remove #include <malloc.h> from a file

This ancient header has long been deprecated in favour of <stdlib.h> but
this file uses GLib memory functions anyway, so neither is required.
Comment 2 Allison Karlitskaya (desrt) 2014-01-07 21:33:31 UTC
Created attachment 265593 [details] [review]
tests: #include <sys/wait.h> for WIFEXITED
Comment 3 Matthew Barnes 2014-01-08 16:01:51 UTC
Thanks, I appreciate the portability improvements.

I do occasionally try to build on OpenBSD, but haven't tried FreeBSD.

Committed for 3.11.4:

https://git.gnome.org/browse/evolution-data-server/commit/?id=fa46f261932906c5a31dc029078927dc7655874c

https://git.gnome.org/browse/evolution-data-server/commit/?id=4c381def04938dd0d35bef2ac6456738025db490