After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721730 - Use proper function for retrieving 'state' property on window object
Use proper function for retrieving 'state' property on window object
Status: RESOLVED FIXED
Product: gedit
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-07 20:58 UTC by sébastien lafargue
Modified: 2014-01-07 22:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use proper function for retrieving 'state' property on window object (888 bytes, patch)
2014-01-07 21:24 UTC, sébastien lafargue
committed Details | Review

Description sébastien lafargue 2014-01-07 20:58:48 UTC
In actual code, g_value_set_enum is use instead of the proper g_value_set_flags
Comment 1 sébastien lafargue 2014-01-07 21:24:03 UTC
Created attachment 265588 [details] [review]
Use proper function for retrieving 'state' property on window object
Comment 2 Ignacio Casal Quinteiro (nacho) 2014-01-07 21:31:22 UTC
Review of attachment 265588 [details] [review]:

Looks good
Comment 3 Ignacio Casal Quinteiro (nacho) 2014-01-07 22:24:27 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.