After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721709 - Remove server grab in calc_showing path
Remove server grab in calc_showing path
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-07 16:24 UTC by Daniel Drake
Modified: 2014-02-13 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: don't grab server during calc_showing (1.62 KB, patch)
2014-01-07 16:25 UTC, Daniel Drake 		committed Details | Review

Description Daniel Drake 2014-01-07 16:24:04 UTC 
This function emits signals under a grab (e.g. via _shell_wm_minimize). We caught a Mali deadlock here when the shell tried to do rendering in response to such signals.

This was added in bug #381127 to combat window flicker. Now that we do compositing, this grab is no longer necessary.
Comment 1 Daniel Drake 2014-01-07 16:25:51 UTC 
Created attachment 265543 [details] [review]
window: don't grab server during calc_showing

This grab was added in commit caf43a123f40d3a68599ac5453a79759b828e8f0
https://bugzilla.gnome.org/show_bug.cgi?id=381127
to minimize window flickering when switching workspaces.

While this grab is held, some signals are emitted to the shell,
which can lead to deadlocks (reproduced under Mali binary OpenGLESv2
drivers).

Now that we are a compositing window manager, we do not have to
worry about flickers, this grab should no longer be necessary.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-07 16:31:14 UTC 
Review of attachment 265543 [details] [review]:

OK.
Comment 3 Daniel Drake 2014-01-07 20:14:40 UTC 
Comment on attachment 265543 [details] [review]
window: don't grab server during calc_showing

Thanks, should I also push to gnome-3-10 and wayland?
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-01-07 20:15:24 UTC 
Yes.
Comment 5 Daniel Drake 2014-02-13 19:00:44 UTC 
This was pushed earlier, forgot to close this bug.