After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721692 - Some patches to the navigation buttons
Some patches to the navigation buttons
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-07 12:00 UTC by Yosef Or Boczko
Modified: 2014-01-07 16:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use symbolic icons in the buttom bar (3.84 KB, patch)
2014-01-07 12:01 UTC, Yosef Or Boczko 		committed Details | Review
Add the "linked" style to the navigation buttons (904 bytes, patch)
2014-01-07 12:01 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-01-07 12:00:29 UTC 
See the patches.
Comment 1 Yosef Or Boczko 2014-01-07 12:01:05 UTC 
Created attachment 265525 [details] [review]
Use symbolic icons in the buttom bar
Comment 2 Yosef Or Boczko 2014-01-07 12:01:21 UTC 
Created attachment 265526 [details] [review]
Add the "linked" style to the navigation buttons
Comment 3 Michael Catanzaro 2014-01-07 15:51:21 UTC 
Review of attachment 265525 [details] [review]:

Looks good. I'm sure you've tested the RTL changes.
Comment 4 Michael Catanzaro 2014-01-07 15:52:03 UTC 
Review of attachment 265526 [details] [review]:

This chops off the left edge of the history combo box.
Comment 5 Yosef Or Boczko 2014-01-07 16:11:40 UTC 
Review of attachment 265525 [details] [review]:

Pushed as 03fd2ee - Use symbolic icons in the buttom bar
Comment 6 Yosef Or Boczko 2014-01-07 16:30:52 UTC 
(In reply to comment #4)
> Review of attachment 265526 [details] [review]:
> 
> This chops off the left edge of the history combo box.

I'm not see nothing...
Comment 7 Michael Catanzaro 2014-01-07 16:56:56 UTC 
I changed the patch to add the style class to left_nav_box instead of navigation_box, and now it works as intended. The problem was that the shadow on the left side of the history combo (to the immediate right of the navigation buttons) was cropped off.

Attachment 265526 [details] pushed as efffb0b - Add the "linked" style to the navigation buttons
Comment 8 Michael Catanzaro 2014-01-07 16:58:48 UTC 
Apparently I confused git bz: the patch you attached was not quite the one that was pushed.

Anyway, thanks: it looks a lot nicer now.