GNOME Bugzilla – Bug 721642
Assorted fixes from coverity scan
Last modified: 2014-01-20 09:32:31 UTC
.
Created attachment 265453 [details] [review] raitv: Fix possible out-of-bounds array access get_theme_index_from_id() might return a negative value, which might end up causing out-of-bounds array accesses. Instead, assert when get_theme_index_from_id() fails to show that an internal error occurred.
Created attachment 265454 [details] [review] raitv: Fix bizarre spacing in function call
Created attachment 265455 [details] [review] youtube: Fix potential crasher ytsrc might be uninitialised, so abort early in that case when called from read_url_async().
Created attachment 265456 [details] [review] tmdb: Fix reversed return arg check grl_tmdb_source_may_resolve() was checking for missing_keys the wrong way around.
Created attachment 265457 [details] [review] jamendo: Fix potential uninitialised use
Comment on attachment 265453 [details] [review] raitv: Fix possible out-of-bounds array access commit 32a0f4393213faf27f255bf9dac7d920778de36e Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jan 6 17:14:32 2014 +0100 raitv: Fix possible out-of-bounds array access get_theme_index_from_id() might return a negative value, which might end up causing out-of-bounds array accesses. Instead, assert when get_theme_index_from_id() fails to show that an internal error occurred. https://bugzilla.gnome.org/show_bug.cgi?id=721642 src/raitv/grl-raitv.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Comment on attachment 265454 [details] [review] raitv: Fix bizarre spacing in function call commit ff117053577f868e8ae1fd27b26b0795a7ffd654 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jan 6 17:17:17 2014 +0100 raitv: Fix bizarre spacing in function call https://bugzilla.gnome.org/show_bug.cgi?id=721642 src/raitv/grl-raitv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comment on attachment 265455 [details] [review] youtube: Fix potential crasher commit 5ebf2ac1cbdfd261d9ad93193a4608c0d844d6b9 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jan 6 17:20:59 2014 +0100 youtube: Fix potential crasher ytsrc might be uninitialised, so abort early in that case when called from read_url_async(). https://bugzilla.gnome.org/show_bug.cgi?id=721642 src/youtube/grl-youtube.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
Comment on attachment 265456 [details] [review] tmdb: Fix reversed return arg check commit 8ddccd23344e0d4500051e89e56f62324568fa7d Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jan 6 17:23:12 2014 +0100 tmdb: Fix reversed return arg check grl_tmdb_source_may_resolve() was checking for missing_keys the wrong way around. https://bugzilla.gnome.org/show_bug.cgi?id=721642 src/tmdb/grl-tmdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
commit 2064f318657e7ab63f6323e220bf15bdc3db86a3 Author: Bastien Nocera <hadess@hadess.net> Date: Mon Jan 6 17:28:15 2014 +0100 jamendo: Fix potential uninitialised use https://bugzilla.gnome.org/show_bug.cgi?id=721642 src/jamendo/grl-jamendo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)