After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721625 - backwards NEWS entry about g_source_remove change
backwards NEWS entry about g_source_remove change
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
2.39.x
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-01-06 11:31 UTC by Colin Watson
Modified: 2014-01-06 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix one-character typo in old NEWS entry (1009 bytes, patch)
2014-01-06 19:00 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Colin Watson 2014-01-06 11:31:02 UTC 
NEWS says:

   - g_source_remove() will not throw a critical in the case that you
     try to remove a non-existent source.  We expect that there is some
     code in the wild that will fall afoul of this new critical but
     considering that we now reuse source IDs, this code is already
     broken and should probably be fixed.

This is exactly backwards: s/not/now/ in the first line would fix it.  I think this would be worth fixing retrospectively.
Comment 1 Allison Karlitskaya (desrt) 2014-01-06 19:00:56 UTC 
Created attachment 265467 [details] [review]
Fix one-character typo in old NEWS entry

Change a very confusing typo "will not" -> "will now" about the
g_critical() on removing non-existent sources.
Comment 2 Allison Karlitskaya (desrt) 2014-01-06 19:03:46 UTC 
Attachment 265467 [details] pushed as 210f96d - Fix one-character typo in old NEWS entry

Hopefully this doesn't cause too much grief with ftpadmin when we upload
the next tarball...