GNOME Bugzilla – Bug 721580
Teleporters might disappear
Last modified: 2014-01-05 23:10:07 UTC
Created attachment 265375 [details] Missing teleporters When I got to the first level with teleporters, none of the teleporters were drawn on the map. They still function, though, they're just invisible. I see four critical warnings, one for each teleporter: (gnibbles:23991): Clutter-Gtk-CRITICAL **: gtk_clutter_texture_set_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed (gnibbles:23991): Clutter-Gtk-CRITICAL **: gtk_clutter_texture_set_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed (gnibbles:23991): Clutter-Gtk-CRITICAL **: gtk_clutter_texture_set_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed (gnibbles:23991): Clutter-Gtk-CRITICAL **: gtk_clutter_texture_set_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed Unfortunately I don't have stack traces, and I haven't seen this before so I doubt it will be easy to reproduce -> severity minor.
Ah they're missing on the next teleporter level, too (the one with the big X).
Created attachment 265377 [details] Stacktrace It's happening always; here's a stacktrace.
dc16e15c9872daa532ad9b72e2e5e7969bd46973 is the first bad commit commit dc16e15c9872daa532ad9b72e2e5e7969bd46973 Author: Bryan Quigley <bryanquigs@src.gnome.org> Date: Sun Oct 20 23:33:17 2013 -0400 Removed blank and unused bonus This one didn't compile, but the next commit "A few blank-unused lines" does and is broken.
Created attachment 265380 [details] [review] Fix teleporters The teleporters became invisible due to an off-by-one introduced because the index into our array of pixbufs for the teleporters is defined separately from all the other indices. Fix the index and relocate its definition.
Review of attachment 265380 [details] [review]: Looks good to me! Sorry I missed that..
Attachment 265380 [details] pushed as 1c88b68 - Fix teleporters