After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721509 - License text contains obsolete FSF postal address
License text contains obsolete FSF postal address
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks: 721455
 
 
Reported: 2014-01-05 05:17 UTC by Andika Triwidada
Modified: 2017-07-03 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update FSF postal address (22.66 KB, patch)
2016-06-26 17:57 UTC, Rafael Fontenelle
committed Details | Review

Description Andika Triwidada 2014-01-05 05:17:14 UTC
These files contain license with obsolete FSF postal address:
gucharmap/configure.ac:# 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/Makefile.am:## 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-block-chapters-model.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-block-chapters-model.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-block-codepoint-list.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-block-codepoint-list.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chapters-model.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chapters-model.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chapters-view.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chapters-view.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-charmap.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-charmap.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chartable.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-chartable.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-codepoint-list.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-codepoint-list.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-init.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-menus.ui:  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02110-1301
gucharmap/gucharmap/gucharmap-mini-fontsel.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-mini-fontsel.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-print-operation.c: *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
gucharmap/gucharmap/gucharmap-print-operation.h:*  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
gucharmap/gucharmap/gucharmap-private.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-script-chapters-model.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-script-chapters-model.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-script-codepoint-list.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-script-codepoint-list.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-search-dialog.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-search-dialog.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-settings.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-settings.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-unicode-info.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-unicode-info.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-window.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap-window.c:       "59 Temple Place, Suite 330, Boston, MA  02110-1301  USA"),
gucharmap/gucharmap/gucharmap-window.h: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/gucharmap.h.in: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/main.c: * 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/gucharmap/org.gnome.Charmap.gschema.xml:  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02110-1301
gucharmap/gucharmap.nsi.in:; 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
gucharmap/pixmaps/Makefile.am:## 59 Temple Place, Suite 330, Boston, MA 02110-1301  USA
Comment 1 Daniel Mustieles 2014-02-07 09:14:36 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 2 Anders Jonsson 2015-07-30 07:45:00 UTC
(In reply to Daniel Mustieles from comment #1)
> This problem has been fixed in the development version. The fix will be
> available in the next major software release. Thank you for your bug report.

What development version? I looked at git master now which gave me the following results, so there are still quite a few lines using the old address:

$ grep -r "Temple Place" . --exclude *.po | wc -l
39

Current address can be seen at: http://www.fsf.org/about/contact/
Comment 3 Daniel Mustieles 2015-07-30 08:19:15 UTC
This patch was done with a script that obviously didn't work properly.

I've reopened the bug, and will try to fix it these days.

Thanks for notifying!
Comment 4 Christian Persch 2015-07-30 10:42:26 UTC
Should just replace the postal address with the online one as per the canonical GPL3 notice.
Comment 5 Rafael Fontenelle 2016-06-26 17:57:52 UTC
Created attachment 330408 [details] [review]
Update FSF postal address

This patch should fix this issue. I used the following command sequence:

for file in $(grep -r "Temple Place" . --exclude *.po | cut -d: -f1); do
  sed -e 's|59 Temple Place, Suite 330, Boston, MA.*|51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA|' -i "$file"
done
Comment 6 Rafael Fontenelle 2017-07-03 14:22:56 UTC
Review of attachment 330408 [details] [review]:

Committed
Comment 7 Piotr Drąg 2017-07-03 14:25:27 UTC
This doesn’t look right:

-       "59 Temple Place, Suite 330, Boston, MA  02110-1301  USA"),
+       "51 Franklin Street, Fifth Floor, Boston, MA 02110-1335 USA

(from gucharmap/gucharmap-window.c)
Comment 8 Rafael Fontenelle 2017-07-03 14:34:54 UTC
Thanks, added  "),  back to the string. Fixed in commit caaf63ec8e240b34f1972b30975b3b9d7cfb1418