After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721484 - License text contains obsolete FSF postal address
License text contains obsolete FSF postal address
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks: 721455
 
 
Reported: 2014-01-05 00:47 UTC by Andika Triwidada
Modified: 2014-01-07 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
coding style fixes (2.26 KB, patch)
2014-01-06 14:41 UTC, Guillaume Desmottes 		committed Details | Review
Update FSF postal address (5.26 KB, patch)
2014-01-06 14:41 UTC, Guillaume Desmottes 		committed Details | Review
mock-pkcs11: use g_hash_table_unref() (1.02 KB, patch)
2014-01-06 14:41 UTC, Guillaume Desmottes 		committed Details | Review
run coding style checks on tests (2.33 KB, patch)
2014-01-06 14:41 UTC, Guillaume Desmottes 		committed Details | Review

Description Andika Triwidada 2014-01-05 00:47:46 UTC 
These files has obsolete license
empathy/tests/interactive/test-empathy-calendar-button.c: * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
empathy/tests/interactive/test-empathy-contact-blocking-dialog.c: * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
empathy/tests/interactive/test-empathy-presence-chooser.c: * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
empathy/tests/interactive/test-empathy-status-preset-dialog.c: * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
empathy/tests/mock-pkcs11.c: * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
empathy/tests/mock-pkcs11.h: * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
Comment 1 Guillaume Desmottes 2014-01-06 14:41:21 UTC 
Oh actually we already have a script checking for that. It wasn't just used on tests :)
Comment 2 Guillaume Desmottes 2014-01-06 14:41:33 UTC 
Created attachment 265441 [details] [review]
coding style fixes
Comment 3 Guillaume Desmottes 2014-01-06 14:41:36 UTC 
Created attachment 265442 [details] [review]
Update FSF postal address
Comment 4 Guillaume Desmottes 2014-01-06 14:41:39 UTC 
Created attachment 265443 [details] [review]
mock-pkcs11: use g_hash_table_unref()

Same effect here but g_hash_table_destroy() is banned from our "coding style"
check tools.
Comment 5 Guillaume Desmottes 2014-01-06 14:41:43 UTC 
Created attachment 265444 [details] [review]
run coding style checks on tests
Comment 6 Frederic Peters 2014-01-06 15:02:12 UTC 
To avoid later need for updates, you could adopt what's being suggested by the AGPL, and point the the website,

 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see <http://www.gnu.org/licenses/>.
Comment 7 Guillaume Desmottes 2014-01-06 15:35:30 UTC 
(In reply to comment #6)
> To avoid later need for updates, you could adopt what's being suggested by the
> AGPL, and point the the website,
> 
>  * You should have received a copy of the GNU General Public License
>  * along with this program; if not, see <http://www.gnu.org/licenses/>.

Thanks, I updated my code generation magic to use that from now but I don't really like updating all the files for now. :)
Comment 8 Xavier Claessens 2014-01-06 17:24:02 UTC 
Looks good, +1
Comment 9 Guillaume Desmottes 2014-01-07 08:19:16 UTC 
merged to master.

Attachment 265441 [details] pushed as 5e8fcdc - coding style fixes
Attachment 265442 [details] pushed as 7c3dfe1 - Update FSF postal address
Attachment 265443 [details] pushed as 1bb7262 - mock-pkcs11: use g_hash_table_unref()
Attachment 265444 [details] pushed as 5739650 - run coding style checks on tests