Bug 721453 - ego does not handle UTF-8 correctly
ego does not handle UTF-8 correctly
Status: RESOLVED FIXED
Product: website
Classification: Infrastructure
Component: extensions.gnome.org
current
Other Linux
: Normal normal
: ---
Assigned To: Yuri Konotopov
Shell extensions maintainer(s)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2014-01-04 14:08 UTC by Giovanni Campagna
Modified: 2016-12-01 21:38 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch for #721453 (967 bytes, patch)
2014-01-30 03:38 UTC, mengzhuo 		reviewed Details | Diff | Review
fix #721453 (1.25 KB, patch)
2014-02-14 09:19 UTC, mengzhuo 		accepted-commit_now Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Giovanni Campagna 2014-01-04 14:08:15 UTC 
See https://extensions.gnome.org/review/3543

Above is the diff with the correct UTF-8 characters, below is the full file with the same characters interpreted as Latin-1
Comment 1 mengzhuo 2014-01-30 03:38:15 UTC 
Created attachment 267608 [details] [review]
the patch for #721453

The requirement should be update with Chardet
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-30 13:20:19 UTC 
Review of attachment 267608 [details] [review]:

sorl.thumbnail hasn't been needed for quite a while, so that shouldn't go in requirements.txt.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-01-30 13:20:44 UTC 
Review of attachment 267608 [details] [review]:

(also, it would be appreciated if you used git-bz or git-format-patch to attach a patch with a commit message, instead of just a diff)
Comment 4 mengzhuo 2014-02-14 09:19:25 UTC 
Created attachment 269101 [details] [review]
fix #721453

Thanks for the advise, here is the patch
Comment 5 Jasper St. Pierre (not reading bugmail) 2014-02-14 15:52:08 UTC 
Review of attachment 269101 [details] [review]:

OK.
Comment 6 Yuri Konotopov 2016-12-01 21:38:02 UTC 
Thanks for patch.
Merged to master: https://git.gnome.org/browse/extensions-web/commit/?id=62283374ba4cb2848ea5f2016d979e899c887f72

Will be deployed in few days
Note You need to log in before you can comment on or make changes to this bug.