After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721452 - girwriter: Derive gir namespace from base name
girwriter: Derive gir namespace from base name
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: GObject Introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-04 13:54 UTC by jessevdk@gmail.com
Modified: 2014-01-04 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
girwriter: Derive gir namespace from base name (3.26 KB, patch)
2014-01-04 13:54 UTC, jessevdk@gmail.com 		committed Details | Review

Description jessevdk@gmail.com 2014-01-04 13:54:26 UTC 
Currently, the full filename specified by --gir is used to derive
the namespace. However, it seems to make more sense to only use the
basename (since the argument to --gir is a filename, not a gir name).
Comment 1 jessevdk@gmail.com 2014-01-04 13:54:29 UTC 
Created attachment 265302 [details] [review]
girwriter: Derive gir namespace from base name

Instead of using the full filename specified by --gir to derive the
gir namespace, this patch uses only the base name of the file specified by
--gir.
Comment 2 Luca Bruno 2014-01-04 14:06:55 UTC 
Review of attachment 265302 [details] [review]:

Looks fine, thanks.
Comment 3 jessevdk@gmail.com 2014-01-04 14:29:48 UTC 
Attachment 265302 [details] pushed as 4eb9670 - girwriter: Derive gir namespace from base name