GNOME Bugzilla – Bug 721411
Missing mnemonics for buttons in trash bar
Last modified: 2016-03-01 15:35:36 UTC
Both strings are missing mnemonics: #: ../src/nautilus-trash-bar.c:203 msgid "Restore" #. Translators: "Empty" is an action (for the trash) , not a state #: ../src/nautilus-trash-bar.c:210 msgid "Empty"
Created attachment 269327 [details] [review] tried to fix missing mnemonics
(In reply to comment #1) > Created an attachment (id=269327) [details] [review] > tried to fix missing mnemonics Did you test that patch? I don't see any mnemonic additions here, only string changes.
Comment on attachment 269327 [details] [review] tried to fix missing mnemonics Yeah, this doesn't seem to address the missing mnemonics.
Sorry, misunderstood mnemonics. I'm a beginner. Should I use gtk_widget_add_mnemonic_label ?
You should be able to just use the underscore notation to add a mnemonic, no? Like "_Restore" or "E_mpty Trash".
Created attachment 298064 [details] [review] Added missing mnemonics for trashbar buttons Added missing mnemonics for the 'Restore' (_R) and 'Empty' (_E) buttons at the top of the trash bar.
Thanks for the patch! =)
Created attachment 298072 [details] [review] nautilus-file: explain why is not possible to rename desktop files are managed as a special case, and changes on the file name also affect the contents. But when the content are not a desktop valid format, it generates an error. The only thing that comes to my mind to keep maintaining this special handling of desktop files and also not being in a inconsistent state is to just explain better why we failed to rename.
(In reply to Carlos Soriano from comment #8) > Created attachment 298072 [details] [review] [review] > nautilus-file: explain why is not possible to rename > > desktop files are managed as a special case, and changes on the file > name also affect the contents. But when the content are not a desktop > valid format, it generates an error. > > The only thing that comes to my mind to keep maintaining this special > handling of desktop files and also not being in a inconsistent state is > to just explain better why we failed to rename. whops, wrong number
Comment on attachment 298072 [details] [review] nautilus-file: explain why is not possible to rename Attachment 298072 [details] pushed as 2b7d17a - nautilus-file: explain why is not possible to rename