After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721390 - plugins: do not free debug category in finalize method
plugins: do not free debug category in finalize method
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 719412
 
 
Reported: 2014-01-03 12:59 UTC by Matthieu Bouron
Modified: 2015-04-28 02:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
plugins: do not free debug category in finalize method (932 bytes, patch)
2014-01-03 13:00 UTC, Matthieu Bouron 		none Details | Review

Description Matthieu Bouron 2014-01-03 12:59:32 UTC 
This patch fixes a crash when multiple vaapidecode elements are finalized since the debug category is created once in the class init method.

Looking at how gst debug category is used in the gstreamer code base (and how it is handled internally, ie: preprended to a "global" list), it does not feel wrong to me to not free the gstreamer debug category.
Comment 1 Matthieu Bouron 2014-01-03 13:00:35 UTC 
Created attachment 265215 [details] [review]
plugins: do not free debug category in finalize method
Comment 2 Gwenole Beauchesne 2014-01-06 09:13:07 UTC 
I was sure it fixed a leak mentioned by valgrind, but OK to restore the behaviour to previous versions (<= 0.5.7).
Comment 3 Gwenole Beauchesne 2014-01-06 09:15:49 UTC 
commit 231a067cddc551955fadfb1021f8d6d2b0e1e1ca
Author: Matthieu Bouron <matthieu.bouron@collabora.com>
Date:   Fri Jan 3 12:49:05 2014 +0000

    plugins: do not free debug category in finalize method.
    
    Fixes a crash when multiple vaapidecode elements are finalized since
    the debug category is created once in the class init method.
    
    This is a regression from git commit 7e58d60.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721390
    
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>