After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721355 - context: Always use JSVERSION_LATEST
context: Always use JSVERSION_LATEST
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-02 19:00 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-01-02 19:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
context: Always use JSVERSION_LATEST (29.47 KB, patch)
2014-01-02 19:00 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2014-01-02 19:00:10 UTC 
Upstream wants to remove this API, so let's prepare ourselves for removing it as well...
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-01-02 19:00:13 UTC 
Created attachment 265179 [details] [review]
context: Always use JSVERSION_LATEST

And remove the APIs/ability to scan for a JS version to use.
Upstream wants to remove this API.
Comment 2 Colin Walters 2014-01-02 19:27:20 UTC 
Review of attachment 265179 [details] [review]:

::: gjs/console.cpp
@@ -36,3 @@
     { "command", 'c', 0, G_OPTION_ARG_STRING, &command, "Program passed in as a string", "COMMAND" },
     { "include-path", 'I', 0, G_OPTION_ARG_STRING_ARRAY, &include_path, "Add the directory DIR to the list of directories to search for js files.", "DIR" },
-    { "js-version", 0, 0, G_OPTION_ARG_STRING, &js_version, "JavaScript version (e.g. \"default\", \"1.8\"", "JSVERSION" },

I have a minor concern about applications actually passing this flag, but...eh, they probably don't exist.

::: installed-tests/js/testJS1_8.js
@@ -2,3 @@
-
-// Test SpiderMonkey JS extensions; see
-// https://developer.mozilla.org/en/JavaScript/New_in_JavaScript/1.8

Why not keep this test?  I mean, sure most of it is tested elsewhere, but if we're saying we support these features we should keep the test.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-01-02 19:37:13 UTC 
Attachment 265179 [details] pushed as 3053f0b - context: Always use JSVERSION_LATEST


I'm not sure why I removed that test. Added it back before pushing.