GNOME Bugzilla – Bug 721352
Use gresource for internal modules
Last modified: 2014-01-02 18:04:03 UTC
See patch. Something I thought of last night while in bed, and didn't take me long this morning to actually get working.
Created attachment 265174 [details] [review] Use gresource for internal modules This means that we don't install any JS files to disk anymore, and everything is linked into libgjs.so, hopefully making bootstrap time faster.
Review of attachment 265174 [details] [review]: Looks good to me, provided it passes distcheck and installed/uninstalled tests. Just a small question. ::: Makefile-modules.am @@ +25,3 @@ +nodist_libmodules_resources_la_SOURCES = modules-resources.c modules-resources.h +libmodules_resources_la_CPPFLAGS = $(JS_NATIVE_MODULE_CFLAGS) +libmodules_resources_la_LIBADD = $(JS_NATIVE_MODULE_LIBADD) Why a library and not just straight compiling in libgjs?
(In reply to comment #2) > Why a library and not just straight compiling in libgjs? That seems to be the same thing we do for the other modules (I didn't really want to rearrange too much). If you want a followup patch that removes the static libraries and just adds the sources directly to libgjs_la_SOURCES for all modules, I can do that.
(In reply to comment #3) > (In reply to comment #2) > > Why a library and not just straight compiling in libgjs? > > That seems to be the same thing we do for the other modules (I didn't really > want to rearrange too much). If you want a followup patch that removes the > static libraries and just adds the sources directly to libgjs_la_SOURCES for > all modules, I can do that. Yeah, I was thinking of symbol visibility, but it makes no difference because it's a static library anyway, so let's keep it consistent for now.
Comment on attachment 265174 [details] [review] Use gresource for internal modules pushed but git-bz failed