After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721348 - changing search engine breaks tests
changing search engine breaks tests
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-02 16:42 UTC by William Jon McCann
Modified: 2014-01-07 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix tests if search engine is changed (1.98 KB, patch)
2014-01-03 23:06 UTC, Michael Catanzaro 		committed Details | Review
Improve test_ephy_web_view_normalize_or_autosearch (3.00 KB, patch)
2014-01-03 23:07 UTC, Michael Catanzaro 		committed Details | Review

Description William Jon McCann 2014-01-02 16:42:16 UTC 
Changing the search engine to anything other than ddg breaks tests.
Comment 1 Claudio Saavedra 2014-01-03 13:08:04 UTC 
The EphyWebView test has ddg hardcoded as the search engine. We probably need to fix that test.
Comment 2 Michael Catanzaro 2014-01-03 23:06:41 UTC 
Created attachment 265273 [details] [review]
Fix tests if search engine is changed

test_ephy_web_view_normalize_or_autosearch(): don't assume the default
search engine has never been changed.
Comment 3 Michael Catanzaro 2014-01-03 23:07:43 UTC 
Created attachment 265274 [details] [review]
Improve test_ephy_web_view_normalize_or_autosearch

Run the test using a search engine other than DuckDuckGo, to make sure
changing the search engine works as expected.
Comment 4 Claudio Saavedra 2014-01-07 13:39:38 UTC 
Review of attachment 265273 [details] [review]:

Good!
Comment 5 Claudio Saavedra 2014-01-07 13:42:10 UTC 
Review of attachment 265274 [details] [review]:

Great, thanks.
Comment 6 Michael Catanzaro 2014-01-07 15:54:40 UTC 
Attachment 265273 [details] pushed as 7f5f8cd - Fix tests if search engine is changed
Attachment 265274 [details] pushed as 77a267c - Improve test_ephy_web_view_normalize_or_autosearch