After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721347 - build: Don't override Automake check: target
build: Don't override Automake check: target
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-bluetooth-general-maint@gnome.bugs
gnome-bluetooth-general-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-02 16:30 UTC by Colin Walters
Modified: 2014-01-07 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Don't override Automake check: target (1.26 KB, patch)
2014-01-02 16:30 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-01-02 16:30:49 UTC 
That causes warnings, which are obvious in the Continuous build view.
Instead, since the goal of this code is to execute xmllint, use a
stamp file target.

This fixes the warnings, and furthermore ensures that we only run
xmllint when the source file changes, instead of on every invocation
of make.
Comment 1 Colin Walters 2014-01-02 16:30:51 UTC 
Created attachment 265161 [details] [review]
build: Don't override Automake check: target
Comment 2 Bastien Nocera 2014-01-07 07:31:42 UTC 
Review of attachment 265161 [details] [review]:

Looks good.
Comment 3 Colin Walters 2014-01-07 13:44:19 UTC 
Attachment 265161 [details] pushed as 97659c6 - build: Don't override Automake check: target