After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721317 - Fix crash in testbbox and update gtkenum docs
Fix crash in testbbox and update gtkenum docs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-01 22:34 UTC by Clayton Walker
Modified: 2014-01-04 19:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove references to GTK_BUTTONBOX_DEFAULT_STYLE (1.55 KB, patch)
2014-01-01 22:34 UTC, Clayton Walker 		none Details | Review
Updated to fix crash and clean up test (2.70 KB, patch)
2014-01-01 23:45 UTC, Clayton Walker 		none Details | Review

Description Clayton Walker 2014-01-01 22:34:14 UTC 
Created attachment 265114 [details] [review]
Remove references to GTK_BUTTONBOX_DEFAULT_STYLE

Both gtkenums.h and testbbox.c reference GTK_BUTTONBOX_DEFAULT_STYLE, an unimplemented and undocumented flag. Running testbbox and chosing said flag causes a crash due to unidentified behavior.

Attached is a patch that removes the flag from both the gtkenums comments and the testbbox test. It also properly select the default style.
Comment 1 Clayton Walker 2014-01-01 23:45:36 UTC 
Created attachment 265115 [details] [review]
Updated to fix crash and clean up test

Updated patch fixes crash and uses get_active instead of get_active_test.