After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721292 - No spaces between em dash in file operation dialog
No spaces between em dash in file operation dialog
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.10.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-31 21:18 UTC by Piotr Drąg
Modified: 2014-03-31 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A screenshot of the issue (59.71 KB, image/png)
2013-12-31 21:18 UTC, Piotr Drąg 		  Details
file-operations: Add spaces between em dashes (6.42 KB, patch)
2014-03-31 08:17 UTC, Ross Lagerwall 		none Details | Review
file-operations: Add spaces between em dashes (1.11 KB, patch)
2014-03-31 08:19 UTC, Ross Lagerwall 		committed Details | Review

Description Piotr Drąg 2013-12-31 21:18:39 UTC 
Created attachment 265088 [details]
A screenshot of the issue

Some of the strings used in the file operation dialog are combined from three parts, like "%'d file left to delete" + "—" + "%T left". There are, however, no spaces between em dash and the rest, making the resulting string a bit clunky (see the screenshot).


I think this is the part responsible, but I might be wrong: https://git.gnome.org/browse/nautilus/tree/libnautilus-private/nautilus-file-operations.c#n1494
Comment 1 Ross Lagerwall 2014-03-31 08:17:20 UTC 
Created attachment 273319 [details] [review]
file-operations: Add spaces between em dashes

Add spaces between em dashes when reporting delete progress for
consistency with the reporting of copy progress.
Comment 2 Ross Lagerwall 2014-03-31 08:19:19 UTC 
Created attachment 273320 [details] [review]
file-operations: Add spaces between em dashes

Add spaces between em dashes when reporting delete progress for
consistency with the reporting of copy progress.
Comment 3 Cosimo Cecchi 2014-03-31 16:46:39 UTC 
Review of attachment 273320 [details] [review]:

Looks good, thanks.
Comment 4 Ross Lagerwall 2014-03-31 20:39:00 UTC 
Pushed to master as 89004e521bdadbed35c6969037e1ee80af361a77.