After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721288 - Misc about: issues
Misc about: issues
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-31 19:26 UTC by William Jon McCann
Modified: 2014-01-02 16:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Clean up some style in about: (2.69 KB, patch)
2013-12-31 19:26 UTC, William Jon McCann
committed Details | Review
Remove unused old about page (2.54 KB, patch)
2013-12-31 19:26 UTC, William Jon McCann
committed Details | Review
Add me and jimmac to about dialog (1.08 KB, patch)
2013-12-31 19:26 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2013-12-31 19:26:29 UTC
Here are a few patches for misc about: issues
Comment 1 William Jon McCann 2013-12-31 19:26:31 UTC
Created attachment 265085 [details] [review]
Clean up some style in about:
Comment 2 William Jon McCann 2013-12-31 19:26:34 UTC
Created attachment 265086 [details] [review]
Remove unused old about page
Comment 3 William Jon McCann 2013-12-31 19:26:36 UTC
Created attachment 265087 [details] [review]
Add me and jimmac to about dialog
Comment 4 Reinout van Schouwen 2014-01-01 10:13:18 UTC
Please consider whether the About dialog and about: could be merged.
Comment 5 Claudio Saavedra 2014-01-02 09:51:57 UTC
Review of attachment 265087 [details] [review]:

OK
Comment 6 Claudio Saavedra 2014-01-02 09:52:36 UTC
Review of attachment 265086 [details] [review]:

OK (assuming it distchecks).
Comment 7 Claudio Saavedra 2014-01-02 09:54:34 UTC
Review of attachment 265085 [details] [review]:

Good to clean up, bad to change anything in the visible output if this is here for nostalgia.

::: embed/ephy-about-handler.c
@@ +323,3 @@
                           "<div id=\"ephytext\">"
+                          "“Il semble que la perfection soit atteinte non quand il n'y a plus rien à"
+                          " ajouter, mais quand il n'y a plus rien à retrancher.”"

Why removing the quotation marks? I think we want to leave this as it originally was, no?
Comment 8 William Jon McCann 2014-01-02 13:36:39 UTC
This is adding quotation marks. Because it is a quote and because that is recommended by the GNOME typography guidelines.

I don't see any reason to leave it looking not that good. It is a small change. Just making it look nicer and more polished shouldn't really change the nostalgia should it?
Comment 9 Claudio Saavedra 2014-01-02 15:16:56 UTC
Somehow I read the patch backwards. It's OK to add them.
Comment 10 Claudio Saavedra 2014-01-02 15:17:17 UTC
Review of attachment 265085 [details] [review]:

r+
Comment 11 William Jon McCann 2014-01-02 16:38:06 UTC
Attachment 265085 [details] pushed as 5476c9c - Clean up some style in about:
Attachment 265086 [details] pushed as 138c1b4 - Remove unused old about page
Attachment 265087 [details] pushed as 768f014 - Add me and jimmac to about dialog