GNOME Bugzilla – Bug 721285
Remove the last uses of stock items
Last modified: 2014-01-07 23:11:26 UTC
And remove some other deprecated widgets along the way.
Created attachment 265080 [details] [review] Don't use stock ids for the security state of a page Use an enum instead.
Created attachment 265081 [details] [review] Don't use stock items and deprecated widgets in encoding dialog
Created attachment 265082 [details] [review] Don't use stock and deprecated widgets in prefs dialog
Created attachment 265083 [details] [review] Don't use stock items and deprecated widgets in lang prefs dialog
Created attachment 265084 [details] [review] Sync nautilus floating status bar from nautilus which removes a use of stock items.
Review of attachment 265080 [details] [review]: Looks good.
Review of attachment 265081 [details] [review]: ::: src/resources/epiphany.ui @@ +8,3 @@ <property name="role">epiphany-encoding-chooser</property> + <property name="modal">True</property> + <property name="default_width">400</property> I'd make this small sort of changes separate. @@ -39,3 @@ </child> - <child> - <object class="GtkButton" id="encoding_help_button"> This change should be separate. @@ +90,3 @@ <property name="visible">True</property> <property name="can_focus">False</property> + <property name="xalign">0</property> This is a UI change which doesn't seem to be related to the deprecated widget usage removal either. @@ +127,3 @@ + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label" translatable="yes">_Use a different encoding:</property> Ditto.
Review of attachment 265082 [details] [review]: ::: src/resources/prefs-dialog.ui @@ -45,3 @@ <property name="layout_style">end</property> <child> - <object class="GtkButton" id="helpbutton1"> Ditto the encoding dialog changes.
Review of attachment 265083 [details] [review]: Looks good.
Review of attachment 265084 [details] [review]: I'd swap the subject and commit log content: " Remove use of stock items in floatin status bar By syncing widget from nautilus "
Created attachment 265598 [details] [review] Don't use stock ids for the security state of a page Use an enum instead.
Created attachment 265599 [details] [review] Remove help button from the encoding dialog
Created attachment 265600 [details] [review] Don't use stock items and deprecated widgets in encoding dialog
Created attachment 265601 [details] [review] Remove help button from prefs dialog
Created attachment 265602 [details] [review] Don't use stock and deprecated widgets in prefs dialog
Created attachment 265603 [details] [review] Don't use stock items and deprecated widgets in lang prefs dialog
Created attachment 265604 [details] [review] Remove use of stock items in floating status bar By syncing widget from nautilus
Review of attachment 265598 [details] [review]: Looks good.
Review of attachment 265599 [details] [review]: OK if you think we shouldn't have a help button here.
Review of attachment 265601 [details] [review]: Same here.
Review of attachment 265602 [details] [review]: Looks good.
Review of attachment 265603 [details] [review]: Good.
Review of attachment 265604 [details] [review]: Only read the changes to ephy-embed.c.
Review of attachment 265600 [details] [review]: Looks good, although I see a few things I suspect are not exactly deprecated stuff removal, but let's just update the whole thing as you see.
Attachment 265598 [details] pushed as 3bf0f7d - Don't use stock ids for the security state of a page Attachment 265599 [details] pushed as 7c53b35 - Remove help button from the encoding dialog Attachment 265600 [details] pushed as d7324a6 - Don't use stock items and deprecated widgets in encoding dialog Attachment 265601 [details] pushed as e532c78 - Remove help button from prefs dialog Attachment 265602 [details] pushed as 116810b - Don't use stock and deprecated widgets in prefs dialog Attachment 265603 [details] pushed as 3dc55cf - Don't use stock items and deprecated widgets in lang prefs dialog Attachment 265604 [details] pushed as c92b52c - Remove use of stock items in floating status bar