GNOME Bugzilla – Bug 721248
Hint broken if tile without match is selected
Last modified: 2014-01-08 20:07:53 UTC
* Select a tile, so that it's highlighted * Click Hint * You get no hint, but you do incur the time penalty
This actually works pretty much as intended since it blinks if it finds a matching tile for the already selected one. Only if there is no matching tile, it doesn't blink and it adds the time. There would be several possible fixes: 1. Blink that one tile even if there is no match to indicate exactly that. 2. Don't do anything but don't penalize for time either. 3. Show a message that there was no possible hint for that tile in a different way (and penalize for time or don't) 4. Remove selection and hint for any other possible match, regardless of the selected tile. For fix 1 we simply add selected_tile = null; as first line in game.vala:set_hint() (as far as I can see, this doesn't break anything). The other fixes would be a bit more elaborate but nothing too fancy.
Thanks for investigating. I think I'd prefer 4. I think 1 and 2 would both be confusing.
I agree with you and if no one swoops in I guess I will manage to have a fix in master within a week or so. No need for you to bother. Depending on the size I will also put it into the 3.10 branch if this is alright with you.
Alright, that is fixed now in master and 3.10. Any two tiles that match are flashed if the selected tile has no match, as if no tiles were selected. The selection of the tile remains.
And looking at the comments in the code, it was supposed to flash the one single tile without a match. That the tile didn't flash and a time penalty was still applied, was the "actual bug".