After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721241 - wavparse: Do not support wav with id3 tag
wavparse: Do not support wav with id3 tag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other Linux
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-12-30 16:37 UTC by scerveau
Modified: 2014-01-06 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Wav example with id3 tag (750.00 KB, audio/wav)
2013-12-30 16:37 UTC, scerveau
  Details
Add id3 Fourcc (543 bytes, patch)
2013-12-30 16:39 UTC, scerveau
needs-work Details | Review
Skip id3 Fourcc (591 bytes, patch)
2013-12-30 16:39 UTC, scerveau
needs-work Details | Review
Add id3 Fourcc in gst-plugins-base (961 bytes, patch)
2013-12-31 09:22 UTC, scerveau
committed Details | Review
skip id3 (1.04 KB, patch)
2013-12-31 09:28 UTC, scerveau
none Details | Review
skip id3 tag in gstwavparse.c (1.04 KB, patch)
2013-12-31 09:30 UTC, scerveau
committed Details | Review

Description scerveau 2013-12-30 16:37:50 UTC
Created attachment 265044 [details]
Wav example with id3 tag

Some wav file with id3 tag inside are not supported by wavparse.

wavparse gstwavparse.c:1624:gst_wavparse_stream_headers:<wavparse0> error: Invalid WAV header (no fmt at start): id3
Comment 1 scerveau 2013-12-30 16:39:03 UTC
Created attachment 265045 [details] [review]
Add id3 Fourcc

patch riff_ids.h in gst-plugin-base
Comment 2 scerveau 2013-12-30 16:39:53 UTC
Created attachment 265046 [details] [review]
Skip id3 Fourcc

patch to be applied in gst-plugins-good.
This patch allows to skip id3 fourcc tag.
Comment 3 Sebastian Dröge (slomo) 2013-12-31 09:05:12 UTC
Please attach both patches in "git format-patch" format. For this commit the changes locally with GIT and then run "git format-patch -1" for example.

Also make sure that your real name and mail address is set up in the GIT config.
Comment 4 scerveau 2013-12-31 09:22:09 UTC
Created attachment 265061 [details] [review]
Add id3 Fourcc in gst-plugins-base

This patch needs to be applied in gst-plugins-base
Comment 5 scerveau 2013-12-31 09:28:07 UTC
Created attachment 265062 [details] [review]
skip id3
Comment 6 scerveau 2013-12-31 09:30:12 UTC
Created attachment 265063 [details] [review]
skip id3 tag in gstwavparse.c

This patch needs add id3 fourcc in gst-plugins-base
Comment 7 Sebastian Dröge (slomo) 2013-12-31 09:39:50 UTC
commit e7912641c3cf3513a13382a5a78ca18bc5ebb476
Author: Stéphane Cerveau <scerveau@gmail.com>
Date:   Tue Dec 31 10:25:28 2013 +0100

    wavparse: Skip id3 tag
    
    Skip id3 tag during wav parse.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721241


commit 9f3becdf52ad06c5d30a58501480036059820d24
Author: Stéphane Cerveau <scerveau@gmail.com>
Date:   Tue Dec 31 10:17:55 2013 +0100

    riff: Add id3 tag
    
    Add id3 tag for wavparse
    
    https://bugzilla.gnome.org/show_bug.cgi?id=721241