GNOME Bugzilla – Bug 721241
wavparse: Do not support wav with id3 tag
Last modified: 2014-01-06 10:02:38 UTC
Created attachment 265044 [details] Wav example with id3 tag Some wav file with id3 tag inside are not supported by wavparse. wavparse gstwavparse.c:1624:gst_wavparse_stream_headers:<wavparse0> error: Invalid WAV header (no fmt at start): id3
Created attachment 265045 [details] [review] Add id3 Fourcc patch riff_ids.h in gst-plugin-base
Created attachment 265046 [details] [review] Skip id3 Fourcc patch to be applied in gst-plugins-good. This patch allows to skip id3 fourcc tag.
Please attach both patches in "git format-patch" format. For this commit the changes locally with GIT and then run "git format-patch -1" for example. Also make sure that your real name and mail address is set up in the GIT config.
Created attachment 265061 [details] [review] Add id3 Fourcc in gst-plugins-base This patch needs to be applied in gst-plugins-base
Created attachment 265062 [details] [review] skip id3
Created attachment 265063 [details] [review] skip id3 tag in gstwavparse.c This patch needs add id3 fourcc in gst-plugins-base
commit e7912641c3cf3513a13382a5a78ca18bc5ebb476 Author: Stéphane Cerveau <scerveau@gmail.com> Date: Tue Dec 31 10:25:28 2013 +0100 wavparse: Skip id3 tag Skip id3 tag during wav parse. https://bugzilla.gnome.org/show_bug.cgi?id=721241 commit 9f3becdf52ad06c5d30a58501480036059820d24 Author: Stéphane Cerveau <scerveau@gmail.com> Date: Tue Dec 31 10:17:55 2013 +0100 riff: Add id3 tag Add id3 tag for wavparse https://bugzilla.gnome.org/show_bug.cgi?id=721241