After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721162 - network: give an empty title to the hotspot dialog
network: give an empty title to the hotspot dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 723200 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-12-28 17:35 UTC by Frederic Peters
Modified: 2014-01-29 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: give an empty title to the hotspot dialog (942 bytes, patch)
2013-12-28 17:35 UTC, Frederic Peters 		committed Details | Review

Description Frederic Peters 2013-12-28 17:35:48 UTC 
The hotspot dialog doesn't specify a title at all, so it gets
"gnome-control-center" displayed.

This explicitely sets an empty title to the dialog.
Comment 1 Frederic Peters 2013-12-28 17:35:50 UTC 
Created attachment 264975 [details] [review]
network: give an empty title to the hotspot dialog
Comment 2 Bastien Nocera 2014-01-08 13:12:31 UTC 
Review of attachment 264975 [details] [review]:

Looks fine, but the commit subject should contain the rationale for the change (which you put in the bug report).

Looks good to commit after that.
Comment 3 Frederic Peters 2014-01-08 13:23:31 UTC 
Attachment 264975 [details] pushed as cde472b - network: give an empty title to the hotspot dialog
Comment 4 Bastien Nocera 2014-01-29 10:39:58 UTC 
*** Bug 723200 has been marked as a duplicate of this bug. ***