After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721132 - Support build with -Werror=format-security
Support build with -Werror=format-security
Status: RESOLVED FIXED
Product: gnome-commander
Classification: Other
Component: buildsystem
unspecified
Other Linux
: Normal normal
: 1.4
Assigned To: GNOME Commander maintainer(s)
epiotr
Depends on:
Blocks:
 
 
Reported: 2013-12-27 15:39 UTC by Mamoru TASAKA
Modified: 2014-01-08 08:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for master branch (4.07 KB, patch)
2013-12-27 15:42 UTC, Mamoru TASAKA 		none Details | Review
Patch for gcmd-1-2-8 branch (4.42 KB, patch)
2013-12-27 15:42 UTC, Mamoru TASAKA 		none Details | Review

Description Mamoru TASAKA 2013-12-27 15:39:32 UTC 
Recently Fedora has added "-Werror=format-string" to compiler flag to strengten security defence, ref:

https://fedoraproject.org/wiki/Changes/FormatSecurity
https://fedoraproject.org/wiki/Format-Security-FAQ
https://lists.fedoraproject.org/pipermail/devel/2013-November/192281.html

Currently released 1.2.8.16 tarball, git gcmd-1-2-8 branch, git master branch, all fail to build with this flag. Please support build with -Werror=format-string
Comment 1 Mamoru TASAKA 2013-12-27 15:42:07 UTC 
Created attachment 264934 [details] [review]
Patch for master branch
Comment 2 Mamoru TASAKA 2013-12-27 15:42:36 UTC 
Created attachment 264935 [details] [review]
Patch for gcmd-1-2-8 branch
Comment 3 Mamoru TASAKA 2013-12-27 16:00:35 UTC 
Oops... actually "-Werror=format-security"
Comment 4 Uwe Scholz 2014-01-07 18:28:27 UTC 
Thank you! I committed your patches. But I cant change bug status by now, as I don't have permissions yet.
Comment 5 Uwe Scholz 2014-01-08 08:32:12 UTC 
Build with -Werror=format-security is supported in the next release and in the current master- and gcmd-1.2.8.branch.