GNOME Bugzilla – Bug 721128
Make Evolution-Data-Server build under Win32
Last modified: 2014-06-01 19:20:14 UTC
Created attachment 264932 [details] [review] eds364-win32.patch Please consider attached patch, which permits Evolution-Data-Server to build and work under Win32. It basically adds configure checks, makes gnome-keyring optional, reimplements platform-specific functions, and avoids use of win32-reserved type names.
Created attachment 264933 [details] [review] configureac.patch
Thanks for the patches, but these are for an obsolete version (3.6). Patches need to apply cleanly to the latest code in git.
Tarnyko, are you still willing to update the patches, please? (having bug #722068 on mind as well). It's OK to split it in two pieces, like the replacement of win32-reserved type names being done separately from the rest of the patch.
Created attachment 267550 [details] [review] eds364-win32.patch Right, here's the patch splitted into two parts. By the way, I double-checked, and there're many references to "gcr_" functions in the code ; so this other patch (https://bugzilla.gnome.org/show_bug.cgi?id=710755) needs to be applied before building.
Created attachment 267551 [details] [review] eds364-win32-iface.patch Only "interface -> iface" conversions.
Thanks for the update. I see you still have it for 3.6.4, not for git master (thus none of the patches apply cleanly). Would you mind to provide the patches for git master? It'll be the place where it'll be committed, after all. (Some source files were dropped completely, some were moved to evolution (libedataserverui), and some are just too different for 'patch' that they fail).
Review of attachment 267551 [details] [review]: I just committed this to master, as commit c0f7b47. The other one is still waiting an update to master from 3.6.x.
I made couple win32 related commits into master and stable (3.12), ending with adapted commit for this bug report: Created commit 9a10ad8 in eds master (3.13.3+) [1] Created commit 9e08013 is eds evolution-data-server-3-12 (3.12.3+) [1] https://git.gnome.org/browse/evolution-data-server/commit/?id=9a10ad8